Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-271 - LCM Triomics Configuration + Integration Suite Tests #1878

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

SHIV5T3R
Copy link
Member

Closes sanger/sequencescape#4291

Changes proposed in this pull request

  • Added configuration for the initial steps of the pipeline

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.23%. Comparing base (eb33851) to head (1dad932).
Report is 70 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1878      +/-   ##
===========================================
- Coverage    74.54%   69.23%   -5.32%     
===========================================
  Files          421      429       +8     
  Lines        14379    15482    +1103     
===========================================
  Hits         10719    10719              
- Misses        3660     4763    +1103     
Flag Coverage Δ
javascript 52.07% <ø> (-7.57%) ⬇️
pull_request 74.95% <ø> (?)
push 74.54% <ø> (ø)
ruby 91.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SHIV5T3R SHIV5T3R marked this pull request as ready for review August 28, 2024 12:45
Copy link
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one suggestion.

config/pipelines/high_throughput_lcm_triomics.wip.yml Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Sep 4, 2024

Code Climate has analyzed commit 1dad932 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

@SHIV5T3R SHIV5T3R requested a review from KatyTaylor September 4, 2024 09:36
Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a starting point for the pipeline development, thx.

Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There could be a library type filter for LCM Triomics EMSeq in the pipeline config but I am doing that in EMSeq branch story along with other changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-271 - Configuration and integration test for the start of LCM Triomics Pipeline
4 participants